stub: ensure BlockingClientCall tasks run after cancellation#12372
Open
benjaminp wants to merge 1 commit intogrpc:masterfrom
Open
stub: ensure BlockingClientCall tasks run after cancellation#12372benjaminp wants to merge 1 commit intogrpc:masterfrom
benjaminp wants to merge 1 commit intogrpc:masterfrom
Conversation
benjaminp
changed the title
After canceling a `BlockingClientCall`, the caller may not interact with it further. That means the call executor, a `ThreadSafeThreadlessExecutor`, will not execute any more tasks. There may still be tasks submitted to the call executor, though, until the underlying call completes. Some of these tasks (e.g., server messages available) may leak native resources unless executed. So, we convert the executor to a "direct" executor during cancellation in order to ensure all call tasks run. Fixes grpc#12355.
benjaminp
force-pushed
the
BlockingClientCall-leak
branch
from
df3f751 to
6a6caf9
Compare
ejona86
reviewed
Sep 22, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I expect we really want to drain the executor until the Listener.onClose() is delivered.
Contributor
Author
|
The trouble is I don't think |
Contributor
Author
|
Another option might be to dump post-cancellation tasks on whatever executor would have been used for the call if we didn't force |
Contributor
Author
So you're proposal would be to make public void cancel(String message, Throwable cause) {
writeClosed = true;
call.cancel(message, cause);
boolean interrupted = Thread.interrupted();
while (true) {
try {
executor.waitAndDrain(x -> x.closeState.get() != null, this);
break;
} catch (InterruptedException e) {
interrupted = true;
}
}
if (interrupted) {
Thread.currentThread().interrupt();
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After canceling a
BlockingClientCall, the caller may not interact with it further. That means the call executor, aThreadSafeThreadlessExecutor, will not execute any more tasks. There may still be tasks submitted to the call executor, though, until the underlying call completes. Some of these tasks (e.g., server messages available) may leak native resources unless executed. So, we convert the executor to a "direct" executor during cancellation in order to ensure all call tasks run.Fixes #12355.